]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
appDisplay: Make AllViews folderIcons property private
authorJonas Dreßler <verdre@v0yd.nl>
Thu, 5 Dec 2019 13:06:48 +0000 (14:06 +0100)
committerFlorian Müllner <florian.muellner@gmail.com>
Thu, 5 Dec 2019 15:43:34 +0000 (15:43 +0000)
This property is not used anywhere outside the class, make it private.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/799

js/ui/appDisplay.js

index d10779efd948c7afa6820fbf9966604ae1f3bd77..102197176874bd3458a5605caf95e88092268523 100644 (file)
@@ -330,7 +330,7 @@ var AllView = GObject.registerClass({
         this._pageIndicators.connect('scroll-event', this._onScroll.bind(this));
         this.add_actor(this._pageIndicators);
 
-        this.folderIcons = [];
+        this._folderIcons = [];
 
         this._stack = new St.Widget({ layout_manager: new Clutter.BinLayout() });
         let box = new St.BoxLayout({
@@ -448,7 +448,7 @@ var AllView = GObject.registerClass({
                 icon.visible = true;
         });
 
-        this.folderIcons.forEach(folder => {
+        this._folderIcons.forEach(folder => {
             let folderApps = folder.getAppIds();
             folderApps.forEach(appId => {
                 let appIcon = this._items.get(appId);
@@ -482,7 +482,7 @@ var AllView = GObject.registerClass({
 
         let appSys = Shell.AppSystem.get_default();
 
-        this.folderIcons = [];
+        this._folderIcons = [];
 
         let folders = this._folderSettings.get_strv('folder-children');
         folders.forEach(id => {
@@ -494,7 +494,7 @@ var AllView = GObject.registerClass({
                 icon.connect('apps-changed', this._redisplay.bind(this));
             }
             appIcons.push(icon);
-            this.folderIcons.push(icon);
+            this._folderIcons.push(icon);
         });
 
         // Allow dragging of the icon only if the Dash would accept a drop to
@@ -774,8 +774,8 @@ var AllView = GObject.registerClass({
         this._availWidth = availWidth;
         this._availHeight = availHeight;
         // Update folder views
-        for (let i = 0; i < this.folderIcons.length; i++)
-            this.folderIcons[i].adaptToSize(availWidth, availHeight);
+        for (let i = 0; i < this._folderIcons.length; i++)
+            this._folderIcons[i].adaptToSize(availWidth, availHeight);
     }
 
     _resetOvershoot() {